linux-kernel - Re: gart: factor out common code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed10ee420804170034g73906d04s22a53f4ef3ef495f@mail.gmail.com>
Date:	Thu, 17 Apr 2008 00:34:03 -0700
From:	"SL Baur" <steve@...acs.org>
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	"Pavel Machek" <pavel@....cz>,
	"kernel list" <linux-kernel@...r.kernel.org>,
	"Ingo Molnar" <mingo@...e.hu>
Subject: Re: gart: factor out common code

On 4/16/08, Andi Kleen <andi@...stfloor.org> wrote:
> SL Baur wrote:

> I think the casts make it more clear because the register is 32bit.
>  The only truly ugly bit is naming a variable "tmp".

Good point.

>  > that function is too big to be inlined so you should probably drop the explicit
>  > `inline' and let the compiler decide.

> In a header static inline is needed, otherwise the compiler will warn
>  about an unused static if it's not used which is unfortunate because
>  not every includer wants to use all functions.
>
>  That said the function should probably not be in a header.

Yes.  Agreed.  I'm happy enough having common duplicated
code removed, but I know Ingo is picky about saving space
whenever he can, so I thought I would point it out now before
it becomes a maintenance issue.

Thanks for the feedback.  I'll focus harder on future reviews.

-sb
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/