linux-kernel - Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0804190817280.21302@topaz.pathscale.com>
Date:	Sat, 19 Apr 2008 08:20:49 -0700 (PDT)
From:	Dave Olson <dave.olson@...gic.com>
To:	Roland Dreier <rdreier@...co.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	Ralph Campbell <ralph.campbell@...gic.com>,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, general@...ts.openfabrics.org
Subject: Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git

On Sat, 19 Apr 2008, Roland Dreier wrote:
|  >  drivers/built-in.o: In function `ipath_init_one':
|  >  ipath_driver.c:(.devinit.text+0x1e5bc): undefined reference to `ipath_init_iba7220_funcs'

Yes, that issue should be fixed.  Our preference was to not build
if it wouldn't work.  We'd have to add the conditional check at
the function setup routines.

| I also removed the dependency on HT_IRQ || PCI_MSI in the Kconfig, since
| the iba7220 support should work without it.  I know we discussed this
| before, but looking closer at the code, the dependency seems pointless
| to me, since it's still possible to build a driver that doesn't work if
| a particular system needs, say HT_IRQ, and the user selects PCI_MSI.
| And since iba7220 doesn't need either, we might as well let people build
| that.
| 
| If this is OK with everyone, I will merge this with a proper changelog.

At this point, I guess I'd agree.  We've added checks for "no interrupt"
after the driver is loaded, so I guess that covers the issue well
enough.

Dave Olson
dave.olson@...gic.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/