lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Apr 2008 09:12:06 -0700 From: Roland Dreier <rdreier@...co.com> To: Dave Olson <dave.olson@...gic.com> Cc: Ingo Molnar <mingo@...e.hu>, Ralph Campbell <ralph.campbell@...gic.com>, akpm@...ux-foundation.org, torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org, general@...ts.openfabrics.org Subject: Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git > | > drivers/built-in.o: In function `ipath_init_one': > | > ipath_driver.c:(.devinit.text+0x1e5bc): undefined reference to `ipath_init_iba7220_funcs' > > Yes, that issue should be fixed. Our preference was to not build > if it wouldn't work. We'd have to add the conditional check at > the function setup routines. Not sure I really follow this response... ipath_driver.c has case PCI_DEVICE_ID_INFINIPATH_7220: #ifndef CONFIG_PCI_MSI ipath_dbg("CONFIG_PCI_MSI is not enabled, " "using IntX for unit %u\n", dd->ipath_unit); #endif ipath_init_iba7220_funcs(dd); break; so clearly ipath_init_iba7220_funcs() was intended to be built and used even if CONFIG_PCI_MSI was not defined. From the code it looks like all should work fine if PCI_MSI is not set, so I don't know what you mean about conditional checks. (BTW since I'm looking at this code, "IntX" should probably be capitalized as "INTx" to match what the PCI specs say) - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists