linux-kernel - Re: [PATCH 01/15] ARM minor irq handler cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080419161436.GA8564@xi.wantstofly.org>
Date:	Sat, 19 Apr 2008 18:14:36 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	rmk@....linux.org.uk, linux-arm-kernel@...ts.arm.linux.org.uk,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/15] ARM minor irq handler cleanups

On Fri, Apr 18, 2008 at 08:25:37PM -0400, Jeff Garzik wrote:

> >>This change's main purpose is to prepare for the patchset in
> >>jgarzik/misc-2.6.git#irq-remove, that explores removal of the
> >>never-used 'irq' argument in each interrupt handler.
> >
> >What do you mean?  I know at least one of two interrupt handlers
> >in-tree that use their 'irq' arguments.
> 
> They can use new function get_irqfunc_irq(), similar to the existing 
> method of getting pt_regs for the tiny number of users who need that 
> sort of info, when pt_regs was removed.

Well, you said that the 'irq' argument was never-used, I was merely
saying that I found that not to be the case.


> But after having gone over, literally, every single interrupt handler in 
> the kernel, I can safely say that 99.8% never reference that argument, 
> and 0.1% that do already have the same information via another route.
> 
> That leaves only a few drivers that need it without modification, and 
> even fewer drivers that need it after modification.

Sounds good.

Very-much-liked-by: Lennert Buytenhek <buytenh@...tstofly.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/