linux-kernel - Re: hci_usb: remove macro code obfuscation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080419161842.GC1577@elf.ucw.cz>
Date:	Sat, 19 Apr 2008 18:18:42 +0200
From:	Pavel Machek <pavel@....cz>
To:	Max Krasnyanskiy <maxk@...lcomm.com>
Cc:	Vitaliy Ivanov <vitalivanov@...il.com>,
	Andrew Morton <akpm@...l.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	marcel@...tmann.org, linux-bluetooth@...r.kernel.org
Subject: Re: hci_usb: remove macro code obfuscation

On Wed 2008-04-16 10:19:15, Max Krasnyanskiy wrote:
> Pavel Machek wrote:
>> On Wed 2008-04-16 13:51:37, Vitaliy Ivanov wrote:
>>> On Wed, Apr 16, 2008 at 1:42 PM, Pavel Machek <pavel@....cz> wrote:
>>>>  I had trouble figuring out what the code does. atomic_inc/dec
>>>>  management is actually pretty simple, but it is needlessly obfuscated
>>>>  with macros. Fix that.
>>>>
>>>>  Signed-off-by: Pavel Machek <pavel@...e.cz>
>>>>
>>>>  I had trouble figuring out what the code does. atomic_inc/dec
>>>>  management is actually pretty simple, but it is needlessly obfuscated
>>>>  with macros. Fix that.
>>>>
>>>>  Signed-off-by: Pavel Machek <pavel@...e.cz>
>>>
>>> Got it from the first time;)
>>>
>>> Do you think that now code looks better? As for me it's not...
>>
>> Yes. Hiding & operator deep inside macro is evil for one thing. Plus
>> it is no longer clear what the code does with the macros in there.
>
> In general I would agree in this case it seems to actually make code 
> clearer (I prefer original macros that is).
> Anyway, I do not mind the change.
>
> btw Marcel told me that all this queuing stuff does not actually make sense 
> anymore. USB core did not support this before and HCI driver performance 
> sucked without it. Marcel is telling me that things have changed.
> So. Pavel, while you're at it can you maybe whack that stuff out completely ?
> I mean all this custom _urb stuff that I did was eventually supposed to 
> move into usb core. Then I stopped working on Bluetooth and it never 
> happened. It'd be nice to clean that up since it seems that most of the 
> latest bug reports are related to this urb business.

It seems someone already done that in (mainline) btusb.c

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/