linux-kernel - Re: [PATCH 05/15] drivers/char: minor irq handler cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080419161634.GA16424@devserv.devel.redhat.com>
Date:	Sat, 19 Apr 2008 12:16:34 -0400
From:	Alan Cox <alan@...hat.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	alan@...hat.com, R.E.Wolff@...Wizard.nl,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/15] drivers/char: minor irq handler cleanups

On Fri, Apr 18, 2008 at 07:22:51PM -0400, Jeff Garzik wrote:
> +++ b/drivers/char/cyclades.c
>  	if (unlikely(!ISZLOADED(*cinfo))) {
>  #ifdef CY_DEBUG_INTERRUPTS
> -		printk(KERN_DEBUG "cyz_interrupt: board not yet loaded "
> -				"(IRQ%d).\n", irq);
> +		printk(KERN_DEBUG "cyz_interrupt: board not yet loaded\n");

If you are debugging IRQ funnies you really really want to know which
IRQ or which port.

Ack the rest on the base the __foo_interrupt uglies will go away with the
final change over. A follow up patch to tweak cyclades would be useful and also
to know from Andrew if these are going in so they don't clash with the coding
style cleanups also queued.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/