linux-kernel - Re: [PATCH 2/4] x86: remove unused code and data in nexgen.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Apr 2008 20:51:56 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Dmitri Vorobiev <dmitri.vorobiev@...il.com>, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] x86: remove unused code and data in nexgen.c

"H. Peter Anvin" <hpa@...or.com> writes:

> Dmitri Vorobiev wrote:
>> Nobody calls the function nexgen_init_cpu(), therefore it
>> can be removed. The variable nexgen_cpu_dev is used only by
>> this function, so this patch removes useless data as well.
>> This patch was build-tested using defconfigs for i386 and x86_64.
>> It also survived a few randconfig instances for i386. Runtime
>> tests were performed by booting 32-bit and 64-bit x86 boxen up to
>> the shell prompt.
>
> NAK.  This is broken.
>
> The reason nexgen_cpu_dev is unreferenced is because the file is
> missing a cpu_vendor_dev_register(), which should be added.

If we did that long without it wouldn't it be better to just remove it?

Also NexGen was never shipped anyways, but bought by AMD and became
the K6. So I assume whatever this file is supposed to do is done
by amd.c anyways.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/