linux-kernel - Re: [build bug] iwl-3945-led.c:(.text+0x119e36): undefined reference to `__led_classdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080420.005149.189096986.davem@davemloft.net>
Date:	Sun, 20 Apr 2008 00:51:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mingo@...e.hu
Cc:	linville@...driver.com, tomas.winkler@...el.com,
	linux-kernel@...r.kernel.org, kaber@...sh.net,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	mabbas@...ux.intel.com, ischram@...enet.be, rjw@...k.pl
Subject: Re: [build bug] iwl-3945-led.c:(.text+0x119e36): undefined
 reference to `__led_classdev_unregister'

From: Ingo Molnar <mingo@...e.hu>
Date: Sun, 20 Apr 2008 09:34:41 +0200

>  drivers/built-in.o: In function `iwl3945_led_unregister_led':
>   iwl-3945-led.c:(.text+0x119e36): undefined reference to `__led_classdev_unregister'
>  drivers/built-in.o: In function `iwl3945_led_register_led':
>   iwl-3945-led.c:(.text+0x119ecd): undefined reference to `led_classdev_register'

Thanks for the report.

This is the classic "API_OPTION=m && API_USER=y" problem.

In this case the best fix is probably to use select in the
iwlwifi Kconfig files.  The following patch should cure it.

iwlwifi: Use 'select' for MAC80211_LEDS and LEDS_CLASS instead of 'depends'

Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
index f844b73..c4e631d 100644
--- a/drivers/net/wireless/iwlwifi/Kconfig
+++ b/drivers/net/wireless/iwlwifi/Kconfig
@@ -49,7 +49,9 @@ config IWL4965_HT
 
 config IWL4965_LEDS
 	bool "Enable LEDS features in iwl4965 driver"
-	depends on IWL4965 && MAC80211_LEDS && LEDS_CLASS
+	depends on IWL4965
+	select MAC80211_LEDS
+	select LEDS_CLASS
 	select IWLWIFI_LEDS
 	---help---
 	  This option enables LEDS for the iwlwifi drivers
@@ -134,7 +136,9 @@ config IWL3945_SPECTRUM_MEASUREMENT
 
 config IWL3945_LEDS
 	bool "Enable LEDS features in iwl3945 driver"
-	depends on IWL3945 && MAC80211_LEDS && LEDS_CLASS
+	depends on IWL3945
+	select MAC80211_LEDS
+	select LEDS_CLASS
 	---help---
 	  This option enables LEDS for the iwl3945 driver.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/