linux-kernel - Re: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080421224314.GA963@martell.zuzino.mipt.ru>
Date:	Tue, 22 Apr 2008 02:43:14 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h>

On Tue, Apr 22, 2008 at 12:32:09AM +0300, Adrian Bunk wrote:
> Every file should include the headers containing the externs its global 
> code.

Declaration should be moved to fs/proc/internal.h and included from
there.

> --- a/fs/proc/kmsg.c
> +++ b/fs/proc/kmsg.c
> @@ -11,6 +11,7 @@
>  #include <linux/kernel.h>
>  #include <linux/poll.h>
>  #include <linux/fs.h>
> +#include <linux/proc_fs.h>

No, really. Such included tend to stick forever, so let's do right thing
from beginning.

It would be nice if your scripts put at least some names of
relevant globals into changelog.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/