linux-kernel - Re: firmware_sample_driver.c: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.1.00.0804212348230.1777@dragon.funnycrock.com>
Date:	Mon, 21 Apr 2008 23:49:10 +0200 (CEST)
From:	Jesper Juhl <jesper.juhl@...il.com>
To:	Pavel Machek <pavel@....cz>
cc:	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Trivial patch monkey <trivial@...nel.org>
Subject: Re: firmware_sample_driver.c: fix coding style

On Tue, 1 Apr 2008, Pavel Machek wrote:

> Fix coding style in firmware_sample_driver...
> 
> Signed-off-by: Pavel Machek <pavel@...e.cz>
> 

I've added this patch to the trivial tree.
Thanks Pavel.

/Jesper Juhl



> diff --git a/Documentation/firmware_class/firmware_sample_driver.c b/Documentation/firmware_class/firmware_sample_driver.c
> index 6865cbe..600cdd9 100644
> --- a/Documentation/firmware_class/firmware_sample_driver.c
> +++ b/Documentation/firmware_class/firmware_sample_driver.c
> @@ -34,8 +34,7 @@ static void sample_probe_default(void)
>          const struct firmware *fw_entry;
>  	printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
>  
> -        if(request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0)
> -	{
> +        if (request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0) {
>  		printk(KERN_ERR
>  		       "firmware_sample_driver: Firmware not available\n");
>  		return;
> @@ -56,8 +55,7 @@ static void sample_probe_specific(void)
>  
>  	printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
>  
> -        if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0)
> -	{
> +        if (request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0) {
>  		printk(KERN_ERR
>  		       "firmware_sample_driver: Firmware load failed\n");
>  		return;
> @@ -70,7 +68,7 @@ static void sample_probe_specific(void)
>  }
>  static void sample_probe_async_cont(const struct firmware *fw, void *context)
>  {
> -	if(!fw){
> +	if (!fw) {
>  		printk(KERN_ERR
>  		       "firmware_sample_driver: firmware load failed\n");
>  		return;
> @@ -88,9 +86,8 @@ static void sample_probe_async(void)
>  					 "sample_driver_fw", &ghost_device,
>  					 "my device pointer",
>  					 sample_probe_async_cont);
> -	if(error){
> -		printk(KERN_ERR 
> -		       "firmware_sample_driver:"
> +	if (error) {
> +		printk(KERN_ERR "firmware_sample_driver:"
>  		       " request_firmware_nowait failed\n");
>  	}
>  }
> @@ -105,6 +102,7 @@ static int sample_init(void)
>  	sample_probe_async();
>  	return 0;
>  }
> +
>  static void __exit sample_exit(void)
>  {
>  }
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/