linux-kernel - Re: StackProtector Oopses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080422083408.GB28970@elte.hu>
Date:	Tue, 22 Apr 2008 10:34:08 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Reuben Farrelly <reuben-linuxkernel@...b.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: StackProtector Oopses - Re: 2.6.25-mm1


* Arjan van de Ven <arjan@...radead.org> wrote:

> > yeah. Arjan - any new patches to try that might fix the bootup test?
> 
> I've looked at the disassembly and compared it to mine, and the gcc is 
> doing something... rather unexpected. The only thing I can think of is 
> the patch below, it should make it a ton more robust...

> -	memset(&foo, 0, 2*sizeof(foo)); /* deliberate buffer overflow */
> +	if (current->stack_canary == *(((unsigned long *)&foo)+1))
> +		*(((unsigned long *)&foo)+1) = 0;
> +	else
> +		printk(KERN_ERR "No -ftack-protector canary found\n");

ok, i queued this up. (with the typo that Valdis noticed fixed)

but ... this bug needs to be figured out, not worked around.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/