linux-kernel - Re: [PATCH 04/12] sched: Remove fixed NR_CPUS sized arrays in kernel_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12c511ca0804220916i5c181202pecf8fee7153e54fc@mail.gmail.com>
Date:	Tue, 22 Apr 2008 09:16:49 -0700
From:	"Tony Luck" <tony.luck@...el.com>
To:	"Mike Travis" <travis@....com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/12] sched: Remove fixed NR_CPUS sized arrays in kernel_sched_c v2

On Fri, Apr 4, 2008 at 6:11 PM, Mike Travis <travis@....com> wrote:
>  @@ -7297,6 +7287,11 @@ void __init sched_init_smp(void)
>   #else
>   void __init sched_init_smp(void)
>   {
>  +#if defined(CONFIG_NUMA)
>  +       sched_group_nodes_bycpu = kzalloc(nr_cpu_ids * sizeof(void **),
>  +                                                               GFP_KERNEL);
>  +       BUG_ON(sched_group_nodes_bycpu == NULL);
>  +#endif
>         sched_init_granularity();
>   }
>   #endif /* CONFIG_SMP */

This hunk is causing problems with one of my builds (generic,
uniprocessor). Note
that the #else at the start of this hunk is from a #ifdef CONFIG_SMP ... so I'm
wondering why we need #if defined(CONFIG_NUMA) inside uniprocessor code :-)
How can you have NUMA issues with only one cpu!!!

[I'm also wondering why the config that has the compile problem has CONFIG_SMP=n
and CONFIG_NUMA=y ... but that weirdness exposed this silliness, so
perhaps it isn't
all bad]

Error message is:
kernel/sched.c: In function `sched_init_smp':
kernel/sched.c:7994: error: `sched_group_nodes_bycpu' undeclared
(first use in this function)
kernel/sched.c:7994: error: (Each undeclared identifier is reported only once
kernel/sched.c:7994: error: for each function it appears in.)

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/