linux-kernel - Re: [PATCH 3/8] omfs: add inode routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Apr 2008 22:11:03 -0400
From:	Bob Copeland <me@...copeland.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	akpm@...ux-foundation.org, hch@...radead.org,
	alan@...rguk.ukuu.org.uk, marcin.slusarz@...il.com,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 3/8] omfs: add inode routines

On Mon, Apr 21, 2008 at 05:13:18PM +0200, Miklos Szeredi wrote:
> > +	if (sbi->s_num_blocks != be64_to_cpu(omfs_rb->r_num_blocks)) {
> > +		printk(KERN_ERR "omfs: block count discrepancy between "
> > +			"super and root blocks (%llx, %llx)\n",
> > +			sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks));
> > +		goto out_bh;
> 
> Jump to wrong label.
> 
> Also label names are a bit chaotic.  But that's a matter of taste...

Thanks, fixed and I changed the label names to e.g. out_brelse_bh2.

-- 
Bob Copeland %% www.bobcopeland.com 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/