linux-kernel - Re: [PATCH 3/8] omfs: add inode routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1Jnxhm-0002we-Tx@pomaz-ex.szeredi.hu>
Date:	Mon, 21 Apr 2008 17:13:18 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	me@...copeland.com
CC:	akpm@...ux-foundation.org, hch@...radead.org,
	alan@...rguk.ukuu.org.uk, miklos@...redi.hu,
	marcin.slusarz@...il.com, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, me@...copeland.com
Subject: Re: [PATCH 3/8] omfs: add inode routines

> +	start = clus_to_blk(sbi, be64_to_cpu(omfs_sb->s_root_block));
> +	bh2 = sb_bread(sb, start);
> +	if (!bh2)
> +		goto out_bh;
> +
> +	omfs_rb = (struct omfs_root_block *)bh2->b_data;
> +
> +	sbi->s_bitmap_ino = be64_to_cpu(omfs_rb->r_bitmap);
> +	sbi->s_clustersize = be32_to_cpu(omfs_rb->r_clustersize);
> +
> +	if (sbi->s_num_blocks != be64_to_cpu(omfs_rb->r_num_blocks)) {
> +		printk(KERN_ERR "omfs: block count discrepancy between "
> +			"super and root blocks (%llx, %llx)\n",
> +			sbi->s_num_blocks, be64_to_cpu(omfs_rb->r_num_blocks));
> +		goto out_bh;

Jump to wrong label.

Also label names are a bit chaotic.  But that's a matter of taste...

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/