lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080423170415.00190051.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 23 Apr 2008 17:04:15 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Shi Weihua <shiwh@...fujitsu.com>
Cc:	akpm@...ux-foundation.org, Hugh Dickins <hugh@...itas.com>,
	Mel Gorman <mel@....ul.ie>, balbir@...ux.vnet.ibm.com,
	xemul@...nvz.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [BUGFIX][PATCH] Fix usemap initialization v3

On Wed, 23 Apr 2008 14:19:04 +0800
Shi Weihua <shiwh@...fujitsu.com> wrote:

> KAMEZAWA Hiroyuki wrote::
> > fixed typos.
> > ==
> > usemap must be initialized only when pfn is within zone.
> > If not, it corrupts memory.
> > 
> > And this patch also reduces the number of calls to set_pageblock_migratetype()
> > from
> > 	(pfn & (pageblock_nr_pages -1)
> > to
> > 	!(pfn & (pageblock_nr_pages-1)
> > it should be called once per pageblock.
> > 
> > Changelog.
> > v2->v3
> >  - Fixed typos.
> > v1->v2
> >  - Fixed boundary check.
> >  - Move calculation of pointer for zone struct to out of loop.
> 
> I noticed v3 takes "zone" instead of "zid" in the code line 
> "z = &NODE_DATA(nid)->node_zones[zone];".
> I tested v3, it works well now.
> 
I don't understand why this happens. (I compiled and tested v2...)
v3's "zone" is correct. thank you!

Regards,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ