linux-kernel - Re: [2.6 patch] drivers/base/cpu.c: make code static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2008 14:58:21 +0200
From:	"Bert Wesarg" <bert.wesarg@...glemail.com>
To:	"Adrian Bunk" <bunk@...nel.org>
Cc:	"Mike Travis" <travis@....com>, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] drivers/base/cpu.c: make code static

On Wed, Apr 23, 2008 at 11:52 AM, Adrian Bunk <bunk@...nel.org> wrote:
> This patch makes the following needlessly global code static:
>  - attr_online_map
>  - attr_possible_map
>  - attr_present_map
>
>  Signed-off-by: Adrian Bunk <bunk@...nel.org>
>
>  ---
>  8ab09fe4313384faa5e3577d99845cedccb245bc diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
>  index 6fe4174..da6f4ae 100644
>  --- a/drivers/base/cpu.c
>  +++ b/drivers/base/cpu.c
>  @@ -119,7 +119,7 @@ static ssize_t print_cpus_##type(struct sysdev_class *class, char *buf)     \
>   {                                                                      \
>         return print_cpus_map(buf, &cpu_##type##_map);                  \
>   }                                                                      \
>  -struct sysdev_class_attribute attr_##type##_map =                      \
>  +static struct sysdev_class_attribute attr_##type##_map =               \
>         _SYSDEV_CLASS_ATTR(type, 0444, print_cpus_##type, NULL)
>
>   print_cpus_func(online);
I think the cpu_state_attr array a few lines down should be static too.

Bert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/