[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m1prsgohj9.fsf@frodo.ebiederm.org>
Date: Wed, 23 Apr 2008 05:57:30 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: yhlu.kernel@...il.com
Cc: "Andrew Morton" <akpm@...ux-foundation.org>,
"Ingo Molnar" <mingo@...e.hu>,
"Jesse Barnes" <jbarnes@...tuousgeek.org>,
"Greg KH" <greg@...ah.com>, "David Miller" <davem@...emloft.net>,
"Jeff Garzik" <jeff@...zik.org>,
"linux-pci" <linux-pci@...ey.karlin.mff.cuni.cz>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
James Bottomley <James.Bottomley@...senpartnership.com>,
Sathya Prakash <sathya.prakash@....com>
Subject: Re: [PATCH] pci: let pci_device_shutdown to call pci_disable_msi
Yinghai Lu <yhlu.kernel.send@...il.com> writes:
> this change
>
> | commit 23a274c8a5adafc74a66f16988776fc7dd6f6e51
> | Author: Prakash, Sathya <sathya.prakash@....com>
> | Date: Fri Mar 7 15:53:21 2008 +0530
> |
> | [SCSI] mpt fusion: Enable MSI by default for SAS controllers
> |
> | This patch modifies the driver to enable MSI by default for all SAS chips.
> |
> | Signed-off-by: Sathya Prakash <sathya.prakash@....com>
> | Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>
> |
> cause kexec RHEL 5.1 kernel fail.
>
> root casue: the rhel 5.1 kernel still use INTx emulation.
> and mptscsih_shutdown doesn't call pci_disable_msi to reenable INTx on kexec
> path
>
> so try to call pci_disable_msi in shutdown patch
Ok this looks like a reasonable approach.
Could you please change how this is factored.
And implement a pci_shutdown_msi and a pci_shutdown_msix that
just performs the hardware state change.
Then have pci_disable_msi and pci_disable_msix call them?
That should be much easier to maintain then a adding a function
that takes a magic flag.
That is the design of the shutdown interface and it seems to
work well.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists