linux-kernel - Re: [PATCH] pci: let pci_device_shutdown to call pci_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440804222308o7c749e32oa974e24dd0a95bf0@mail.gmail.com>
Date:	Tue, 22 Apr 2008 23:08:18 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	michael@...erman.id.au
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	"Greg KH" <greg@...ah.com>, "David Miller" <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Jeff Garzik" <jeff@...zik.org>,
	linux-pci <linux-pci@...ey.karlin.mff.cuni.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"James Bottomley" <James.Bottomley@...senpartnership.com>,
	"Sathya Prakash" <sathya.prakash@....com>
Subject: Re: [PATCH] pci: let pci_device_shutdown to call pci_disable_msi

On Tue, Apr 22, 2008 at 10:24 PM, Michael Ellerman
<michael@...erman.id.au> wrote:
> On Tue, 2008-04-22 at 21:48 -0700, Yinghai Lu wrote:
>  > this change
>  >
>  > | commit 23a274c8a5adafc74a66f16988776fc7dd6f6e51
>  > | Author: Prakash, Sathya <sathya.prakash@....com>
>  > | Date:   Fri Mar 7 15:53:21 2008 +0530
>  > |
>  > |     [SCSI] mpt fusion: Enable MSI by default for SAS controllers
>  > |
>  > |     This patch modifies the driver to enable MSI by default for all SAS chips.
>  > |
>  > |     Signed-off-by: Sathya Prakash <sathya.prakash@....com>
>  > |     Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>
>  > |
>  > cause kexec RHEL 5.1 kernel fail.
>  >
>  > root casue: the rhel 5.1 kernel still use INTx emulation.
>  > and mptscsih_shutdown doesn't call pci_disable_msi to reenable INTx on kexec path
>  >
>  > so try to call pci_disable_msi in shutdown patch
>
>  How is kdump going to work? Your shutdown routine won't be called and
>  you'll have the same problem in the 2nd kernel, won't you?

for kdump, the first kernel and second kernel should be same version.

this one is for using kexec to load other kernel that may not have msi
support etc.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/