linux-kernel - Re: [PATCH] pci: let pci_device_shutdown to call pci_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2008 15:24:37 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	yhlu.kernel@...il.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Greg KH <greg@...ah.com>, David Miller <davem@...emloft.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Jeff Garzik <jeff@...zik.org>,
	linux-pci <linux-pci@...ey.karlin.mff.cuni.cz>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Sathya Prakash <sathya.prakash@....com>
Subject: Re: [PATCH] pci: let pci_device_shutdown to call pci_disable_msi

On Tue, 2008-04-22 at 21:48 -0700, Yinghai Lu wrote:
> this change
> 
> | commit 23a274c8a5adafc74a66f16988776fc7dd6f6e51
> | Author: Prakash, Sathya <sathya.prakash@....com>
> | Date:   Fri Mar 7 15:53:21 2008 +0530
> |
> |     [SCSI] mpt fusion: Enable MSI by default for SAS controllers
> |
> |     This patch modifies the driver to enable MSI by default for all SAS chips.
> |
> |     Signed-off-by: Sathya Prakash <sathya.prakash@....com>
> |     Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>
> |
> cause kexec RHEL 5.1 kernel fail.
> 
> root casue: the rhel 5.1 kernel still use INTx emulation.
> and mptscsih_shutdown doesn't call pci_disable_msi to reenable INTx on kexec path
> 
> so try to call pci_disable_msi in shutdown patch

How is kdump going to work? Your shutdown routine won't be called and
you'll have the same problem in the 2nd kernel, won't you?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)