linux-kernel - Re: [PATCH] wireless: rndis_wlan: modparam_workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080424122628.zioaht24o4ko4ww8@naisho.dyndns.info>
Date:	Thu, 24 Apr 2008 12:26:28 +0300
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Roel Kluin <12o3l@...cali.nl>, linux-wireless@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval is
	never below 0.

Quoting Johannes Berg <johannes@...solutions.net>:

>
> Eh, why not make the modparam unsigned and default to 500?
>
> johannes
>

Now that I stop and think about it, that would be better option. The  
modparam already has default value of 500.

Reason why workaround modparam is signed, is that value -1 did have  
some functionality in some early version. That then changed and  
priv->param_workaround_interval changed to unsigned and forgot about  
modparam.

  - Jussi Kivilinna

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/