linux-kernel - Re: [PATCH] wireless: rndis_wlan: modparam_workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080424121613.GA3879@tuxdriver.com>
Date:	Thu, 24 Apr 2008 08:16:13 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Roel Kluin <12o3l@...cali.nl>, linux-wireless@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval is
	never below 0.

On Thu, Apr 24, 2008 at 12:26:28PM +0300, Jussi Kivilinna wrote:
> Quoting Johannes Berg <johannes@...solutions.net>:
>
>>
>> Eh, why not make the modparam unsigned and default to 500?
>>
>> johannes
>>
>
> Now that I stop and think about it, that would be better option. The 
> modparam already has default value of 500.
>
> Reason why workaround modparam is signed, is that value -1 did have some 
> functionality in some early version. That then changed and 
> priv->param_workaround_interval changed to unsigned and forgot about 
> modparam.

I merged the patch, so if you want that behavior we need a new patch.

John
-- 
John W. Linville
linville@...driver.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/