linux-kernel - Re: [Linux-fbdev-devel] [PATCH] atafb: test virtual screen range before subtraction on unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804242304310.21224@anakin>
Date:	Thu, 24 Apr 2008 23:05:55 +0200 (CEST)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Roel Kluin <12o3l@...cali.nl>
cc:	adaplas@...il.com, linux-fbdev-devel@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [Linux-fbdev-devel] [PATCH] atafb: test virtual screen range
 before subtraction on unsigned

On Wed, 23 Apr 2008, Roel Kluin wrote:
> a bit similar to vga16fb,
> ---
> dx and dy are u32's, so the test should occur before the subtraction

Note that fb_copyarea.d[xy] are also u32, while there are many tests
that check for these fields being negative.

> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/video/atafb.c b/drivers/video/atafb.c
> index 5d4fbaa..8f60a8f 100644
> --- a/drivers/video/atafb.c
> +++ b/drivers/video/atafb.c
> @@ -2593,13 +2593,16 @@ static void atafb_copyarea(struct fb_info *info, const struct fb_copyarea *area)
>  	width = x2 - dx;
>  	height = y2 - dy;
>  
> +	if (area->sx + dx < area->dx || area->sy + dy < area->dy)
> +		return;
> +
>  	/* update sx,sy */
>  	sx = area->sx + (dx - area->dx);
>  	sy = area->sy + (dy - area->dy);
>  
>  	/* the source must be completely inside the virtual screen */
> -	if (sx < 0 || sy < 0 || (sx + width) > info->var.xres_virtual ||
> -	    (sy + height) > info->var.yres_virtual)
> +	if (sx + width > info->var.xres_virtual ||
> +			sy + height > info->var.yres_virtual)
>  		return;
>  
>  	if (dy > sy || (dy == sy && dx > sx)) {
> 

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/