linux-kernel - Re: [RFC][PATCH 0/3] Skip I/O merges when disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080425112543.GQ12774@kernel.dk>
Date:	Fri, 25 Apr 2008 13:25:43 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Alan D. Brunelle" <Alan.Brunelle@...com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 0/3] Skip I/O merges when disabled

On Fri, Apr 25 2008, Alan D. Brunelle wrote:
> >>
> >> I'll look into retaining the one-hit cache merge functionality, remove
> >> the errant elv_rqhas_del code, and repost w/ the results from the other
> >> tests I've run.
> > 
> > Also please do a check where you only disable the front merge logic, as
> > that is the most expensive bit (and the least likely to occur). I would
> > not be surprised if just removing the front merge bit would get you the
> > majority of the gain already. I have in the past considered just getting
> > rid of that bit, as it rarely triggers and it is a costly rbtree lookup
> > for each IO. The back merge lookup+merge should be cheaper, it's just a
> > hash lookup.
> > 
> 
> I have the results from leaving in just the one-hit cache merge
> attempts, and started a run leaving in both that and the back-merge
> rq_hash checks. (The patch below basically undoes patch 3/3 - putting
> back in the addition of rqs onto the hash list, and moves the nomerges
> check below the back merge attempts.)
> 
> We /could/ change the tunable to a dial (or a mask) - enabling/disabling
> specific merge attempts, but that seems a bit confusing/complex.
> 
> Jens: What do you think?

I think we should keep it simple. I don't particularly like having a
switch to toggle merges, no one will ever use it. So I'm more inclined
to just disable front merges unconditionally if the theory of where
the cycles are spent holds up. We'll still do front merges on the
one-hit cache, just not spend time looking up an io context and request
in the rbtree for basically no gain.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/