linux-kernel - Re: [2.6 patch] libata-acpi.c: remove unneeded #if's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48116294.80106@garzik.org>
Date:	Fri, 25 Apr 2008 00:48:20 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Tejun Heo <htejun@...il.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] libata-acpi.c: remove unneeded #if's

Adrian Bunk wrote:
> These #if's are unneeded since they:
> - did anyway not handle the CONFIG_ACPI_DOCK_MODULE case correctly and
> - this is already handled in include/acpi/acpi_drivers.h and
> - it's now correctly handled in kconfig.
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> Acked-by: Tejun Heo <htejun@...il.com>
> 
> ---
> 
> This patch has been sent on:
> - 14 Apr 2008
> - 31 Mar 2008
> 
>  drivers/ata/libata-acpi.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> 2a7326b50cd80e6570803d4efb7bc15e029e61e3 diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index bf98a56..1db912e 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -227,11 +227,9 @@ void ata_acpi_associate(struct ata_host *host)
>  			acpi_install_notify_handler(ap->acpi_handle,
>  						    ACPI_SYSTEM_NOTIFY,
>  						    ata_acpi_ap_notify, ap);
> -#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
>  			/* we might be on a docking station */
>  			register_hotplug_dock_device(ap->acpi_handle,
>  						     ata_acpi_ap_notify, ap);
> -#endif
>  		}
>  
>  		for (j = 0; j < ata_link_max_devices(&ap->link); j++) {
> @@ -241,11 +239,9 @@ void ata_acpi_associate(struct ata_host *host)
>  				acpi_install_notify_handler(dev->acpi_handle,
>  						ACPI_SYSTEM_NOTIFY,
>  						ata_acpi_dev_notify, dev);
> -#if defined(CONFIG_ACPI_DOCK) || defined(CONFIG_ACPI_DOCK_MODULE)
>  				/* we might be on a docking station */
>  				register_hotplug_dock_device(dev->acpi_handle,
>  						ata_acpi_dev_notify, dev);
> -#endif

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/