linux-kernel - Re: [2.6 patch] make sata_print_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4811629D.3040601@pobox.com>
Date:	Fri, 25 Apr 2008 00:48:29 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Adrian Bunk <bunk@...nel.org>
CC:	Mark Lord <mlord@...ox.com>, Jeff Garzik <jgarzik@...hat.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] make sata_print_link_status() static

Adrian Bunk wrote:
> sata_print_link_status() can now become static.
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> 
>  drivers/ata/libata-core.c |    3 +--
>  include/linux/libata.h    |    1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> 017dd9ea17af28a805e099c245ae1f8991eb6b5a diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 1686773..4b918d7 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -2605,7 +2605,7 @@ void ata_port_probe(struct ata_port *ap)
>   *	LOCKING:
>   *	None.
>   */
> -void sata_print_link_status(struct ata_link *link)
> +static void sata_print_link_status(struct ata_link *link)
>  {
>  	u32 sstatus, scontrol, tmp;
>  
> @@ -6197,7 +6197,6 @@ EXPORT_SYMBOL_GPL(ata_host_detach);
>  EXPORT_SYMBOL_GPL(ata_sg_init);
>  EXPORT_SYMBOL_GPL(ata_qc_complete);
>  EXPORT_SYMBOL_GPL(ata_qc_complete_multiple);
> -EXPORT_SYMBOL_GPL(sata_print_link_status);
>  EXPORT_SYMBOL_GPL(atapi_cmd_type);
>  EXPORT_SYMBOL_GPL(ata_tf_to_fis);
>  EXPORT_SYMBOL_GPL(ata_tf_from_fis);
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 2d8874b..84618df 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -847,7 +847,6 @@ static inline int ata_port_is_dummy(struct ata_port *ap)
>  	return ap->ops == &ata_dummy_port_ops;
>  }
>  
> -extern void sata_print_link_status(struct ata_link *link);
>  extern void ata_port_probe(struct ata_port *);
>  extern int sata_set_spd(struct ata_link *link);
>  extern int ata_std_prereset(struct ata_link *link, unsigned long deadline);

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/