linux-kernel - Re: mainline boot failures I: qemu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080426154241.GH5882@ZenIV.linux.org.uk>
Date:	Sat, 26 Apr 2008 16:42:41 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	mingo@...e.hu, tglx@...utronix.de, torvalds@...l.org,
	linux-kernel@...r.kernel.org
Subject: Re: mainline boot failures I: qemu

On Sat, Apr 26, 2008 at 04:02:10PM +0200, Andi Kleen wrote:
> 
> FYI
> 
> I see lots of boot failures on various setups with current mainline
> (git8, b1721d0da266b4af8cb4419473b4ca36206ab200). Unfortunately 
> they are all different. 

See http://lkml.org/lkml/2008/4/26/1

FWIW, I've reconstructed what had happened:
	* broken changeset in local tree
	* breakage caught, fixed (still in local tree)
	* cherry-pick into new branch in local tree, fix folded
	* *old* changeset taken into the public tree
	* a couple of days later Linus asked to pull
	* pull from Linus' tree into local triggering conflict
	* what the... oh, hell.

Again, the missing bit is this, see if it fixes all of the breakage
you see.  It's a memory corruptor that got immediately caught in
testing, of course - most of the boots don't even get past exec
of /sbin/init.

Brown paperbag time ;-/

diff --git a/kernel/fork.c b/kernel/fork.c
index 4df3949..a647542 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1788,7 +1788,7 @@ bad_unshare_out:
 int unshare_files(struct files_struct **displaced)
 {
 	struct task_struct *task = current;
-	struct files_struct *copy;
+	struct files_struct *copy = NULL;
 	int error;
 
 	error = unshare_fd(CLONE_FILES, &copy);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/