linux-kernel - Re: [RFC git pull] "big box" x86 changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0804261205490.2813@woody.linux-foundation.org>
Date:	Sat, 26 Apr 2008 12:12:33 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, Yinghai Lu <yinghai.lu@....com>,
	Yinghai Lu <yhlu.kernel@...il.com>, jbarnes@...tuousgeek.org
Subject: Re: [RFC git pull] "big box" x86 changes

On Sat, 26 Apr 2008, Ingo Molnar wrote:
> 
> So we need a bit of help wrt. how mergable this is, and what else is 
> needed to make it mergable. These changes have been booted all across 
> the x86 spectrum, small and large boxes alike, so i'd be seriously 
> surprised if they caused any widespread breakage.

I'd like to see this sent as perhaps four independent pulls (where 
"independent" doesn't necessarily mean that they don't depend on each 
other and have some ordering, but is more of a "this is the bootup 
changes" vs "these are bootmem-related" etc, if at all possible. 

Quite frankly, from a review standpoint, very few people should need to 
(or want to) review individual commits when there are 50 of them (they 
might only care about the changes that 3 or 4 of them make, but they get 
lost in the noise), but at the same time, if you have a single diffstat 
like this:

	45 files changed, 2071 insertions(+), 362 deletions(-)

then you're also going to have people not able to give good feedback.

In contrast, if you send out an email like this one, but that has the 
combined diff of say 10 commits in one area, and the diff is a couple of 
hundred lines of changes rather than almost 2,500 lines, then you'll 
definitely get people who are able and willing to look at four chunks like 
that.

IOW, they'd be big enough that people hopefully don't start nitpicking 
about some *totally* uninteresting small detail, but small enough that 
people can read it through without losing concentration about a quarter of 
the way in.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/