linux-kernel - Re: [patch] pcspkr: fix dependancies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Apr 2008 19:18:14 -0400
From:	Dmitry Torokhov <dtor-oss@...cast.net>
To:	Stas Sergeev <stsp@...et.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>,
	Linux kernel <linux-kernel@...r.kernel.org>,
	Vojtech Pavlik <vojtech@...e.cz>
Subject: Re: [patch] pcspkr: fix dependancies

Hi Stas,

On Saturday 26 April 2008, Stas Sergeev wrote:
> Hello.
> 
> linux-2.6.25 has the strange dependancies
> for pc-speaker, which prevents snd-pcsp
> from working.
> Namely, the platform device (created in
> arch/x86/kernel/pcspeaker.c) depends on
> the platform driver (CONFIG_INPUT_PCSPKR).
> I wonder if it is a good practice to make
> the platform device to depend on the driver,
> I guess it is not.
> 
> The attached patch reverses that.
> It adds the config option for the pcspkr
> platform device and makes the platform
> drivers to depend on that.
> This allows snd-pcsp to work at least in
> some configurations.
> 

No, not another config option please. Either make pcspkr platform
device be created unconditionally or if either pcspkr or snd-pcsp
is selected. 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/