linux-kernel - [patch] pcspkr: fix dependancies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4813476A.7000705@aknet.ru>
Date:	Sat, 26 Apr 2008 19:16:58 +0400
From:	Stas Sergeev <stsp@...et.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Takashi Iwai <tiwai@...e.de>,
	Linux kernel <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Vojtech Pavlik <vojtech@...e.cz>
Subject: [patch] pcspkr: fix dependancies

Hello.

linux-2.6.25 has the strange dependancies
for pc-speaker, which prevents snd-pcsp
from working.
Namely, the platform device (created in
arch/x86/kernel/pcspeaker.c) depends on
the platform driver (CONFIG_INPUT_PCSPKR).
I wonder if it is a good practice to make
the platform device to depend on the driver,
I guess it is not.

The attached patch reverses that.
It adds the config option for the pcspkr
platform device and makes the platform
drivers to depend on that.
This allows snd-pcsp to work at least in
some configurations.

Does that patch look reasonable?

---
fix pcspkr dependancies: make the pcspkr platform
drivers to depend on a platform device, and
not the other way around.

Signed-off-by: Stas Sergeev <stsp@...et.ru>
CC: Takashi Iwai <tiwai@...e.de>
CC: Dmitry Torokhov <dmitry.torokhov@...il.com>
CC: Vojtech Pavlik <vojtech@...e.cz>

View attachment "pcsp_dep.diff" of type "text/x-patch" (1798 bytes)