linux-kernel - Re: [patch] pcspkr: fix dependancies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080427042331.GB29127@anvil.corenet.prv>
Date:	Sun, 27 Apr 2008 00:23:31 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Stas Sergeev <stsp@...et.ru>
Cc:	Dmitry Torokhov <dtor-oss@...cast.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>,
	Linux kernel <linux-kernel@...r.kernel.org>,
	Vojtech Pavlik <vojtech@...e.cz>,
	Michael Opdenacker <michael@...e-electrons.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch] pcspkr: fix dependancies

On Sun, Apr 27, 2008 at 03:39:37AM +0400, Stas Sergeev wrote:
> Hello.
> 
> Dmitry Torokhov wrote:
> > No, not another config option please. Either make pcspkr platform
> > device be created unconditionally
> I also think this would be the best
> fix. But this will return us to the
> state of 2.6.24. Presumably the dependancy
> was added for the reason, even if I
> fail to see one.
> But in any case, the patch is attached.
> 
> > or if either pcspkr or snd-pcsp
> > is selected.
> I don't think it is correct, but if
> people think it is, then this can be
> done.
> 

It looks like the change was introduced by commit

67926892ef7a7fbc76de607120d44416019fdf07

I think that we should register devices even if there is no driver in
the kernel for it because driver may be compiled at later time or be out
of tree. Adding patch author and other people that signed off the patch
to CC...

> 
> ---
> Compile pcspkr platform device unconditionally.
> That allows snd-pcsp to work.
> 
> Signed-off-by: Stas Sergeev <stsp@...et.ru>

> --- a/arch/x86/kernel/Makefile	2008-04-26 13:40:06.000000000 +0400
> +++ b/arch/x86/kernel/Makefile	2008-04-26 18:22:49.000000000 +0400
> @@ -83,9 +83,7 @@
>  obj-$(CONFIG_VMI)		+= vmi_32.o vmiclock_32.o
>  obj-$(CONFIG_PARAVIRT)		+= paravirt.o paravirt_patch_$(BITS).o
>  
> -ifdef CONFIG_INPUT_PCSPKR
>  obj-y				+= pcspeaker.o
> -endif
>  
>  obj-$(CONFIG_SCx200)		+= scx200.o
>  scx200-y			+= scx200_32.o


-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/