linux-kernel - Re: [PATCH] build fix for smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce0170d90804280201v77e4302crb8171357a3ef3bbc@mail.gmail.com>
Date:	Mon, 28 Apr 2008 06:01:34 -0300
From:	"Sergio Luis" <sergio@...e.br>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"Glauber de Oliveira Costa" <gcosta@...hat.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	tglx@...utronix.de, ak@...e.de, "Avi Kivity" <avi@...ranet.com>
Subject: Re: [PATCH] build fix for smp

On Mon, Apr 28, 2008 at 5:50 AM, Ingo Molnar <mingo@...e.hu> wrote:
>
>  * Sergio Luis <sergio@...e.br> wrote:
>
>  > Hello, what's the final fix for this issue? 2.6.25-git11 is still
>  > broken, just gave me
>
>  > arch/x86/kernel/built-in.o: In function `native_smp_send_stop':
>  > smp.c:(.text+0xc751): undefined reference to `reboot_force'
>  > make: *** [.tmp_vmlinux1] Error 1
>
>  > for a randconfig. Same reported at http://lkml.org/lkml/2008/4/27/39
>
>  btw., that's a VISWS config - that wont boot on any PC. The patch below
>  should fix this.

Yep, it does fix it thanks.
-sergio

>
>         Ingo
>
>  --------------------------->
>  Subject: x86 VISWS: build fix
>  From: Ingo Molnar <mingo@...e.hu>
>  Date: Mon Apr 28 10:46:58 CEST 2008
>
>  the 'reboot_force' flag is a notion that non-PC subarchitectures do
>  not have.
>
>  Signed-off-by: Ingo Molnar <mingo@...e.hu>
>  ---
>   include/asm-x86/proto.h |    4 ++++
>   1 file changed, 4 insertions(+)
>
>  Index: linux/include/asm-x86/proto.h
>  ===================================================================
>  --- linux.orig/include/asm-x86/proto.h
>  +++ linux/include/asm-x86/proto.h
>  @@ -20,7 +20,11 @@ extern void syscall32_cpu_init(void);
>
>   extern void check_efer(void);
>
>  +#ifdef X86_BIOS_REBOOT
>   extern int reboot_force;
>  +#else
>  +static const int reboot_force = 0;
>  +#endif
>
>   long do_arch_prctl(struct task_struct *task, int code, unsigned long addr);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/