linux-kernel - Re: [PATCH] build fix for smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2008 11:16:08 -0300
From:	Glauber Costa <gcosta@...hat.com>
To:	Sergio Luis <sergio@...e.br>
CC:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, tglx@...utronix.de, ak@...e.de
Subject: Re: [PATCH] build fix for smp

Sergio Luis wrote:
> On Wed, Mar 19, 2008 at 4:52 PM, Ingo Molnar <mingo@...e.hu> wrote:
>>  * Glauber de Oliveira Costa <gcosta@...hat.com> wrote:
>>
>>  > +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_BIOS_REBOOT)
>>  >       if (reboot_force)
>>  >               return;
>>  > +#endif
>>
>>  please solve it slightly differently: introduce a uniformly usable
>>  reboot_force flag, that will always default to the constant of 1 if
>>  !X86_64 && !X86_BIOS_REBOOT. That makes the code cleaner - and not the
>>  least i can also merge the fix earlier in the series, without having to
>>  redo the big smp.c movement patch :-)
>>
>>         Ingo
>>
> 
> Hello,
> what's the final fix for this issue? 2.6.25-git11 is still broken, just gave me
Doh. I had the patch, but completely forgot to send it to ingo. Thanks 
for raising this issue again. (But I saw ingo already put a fix for this in)

> arch/x86/kernel/built-in.o: In function `native_smp_send_stop':
> smp.c:(.text+0xc751): undefined reference to `reboot_force'
> make: *** [.tmp_vmlinux1] Error 1
> 
> for a randconfig. Same reported at http://lkml.org/lkml/2008/4/27/39
> 
> thanks,
> -sergio

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/