linux-kernel - Re: ./fs/partitions/check.c: off-by-one error ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080428125652.GD17054@duck.suse.cz>
Date:	Mon, 28 Apr 2008 14:56:53 +0200
From:	Jan Kara <jack@...e.cz>
To:	Toralf Förster <toralf.foerster@....de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: ./fs/partitions/check.c: off-by-one error ?

On Wed 23-04-08 18:42:57, Toralf Förster wrote:
> At Tuesday 22 April 2008 12:38:29 Jan Kara wrote :
> >   This looks more like a strange interaction of your device size (it
> > claims to have 3902463 sectors) and your partitioning programs which
> > create partition ending at sector 3902464. Can you send the partition
> > table you have on the device? E.g:
> >   fdisk /dev/sda
> >   x
> >   p
> > 
> >   will print detailed information about the partition table.
> > 
> 
> n22 ~ # fdisk /dev/sda
> 
> The number of cylinders for this disk is set to 1267.
> There is nothing wrong with that, but this is larger than 1024,
> and could in certain setups cause problems with:
> 1) software that runs at boot time (e.g., old versions of LILO)
> 2) booting and partitioning software from other OSs
>    (e.g., DOS FDISK, OS/2 FDISK)
> 
> Command (m for help): x
> 
> Expert command (m for help): p
> 
> Disk /dev/sda: 56 heads, 55 sectors, 1267 cylinders
> 
> Nr AF  Hd Sec  Cyl  Hd Sec  Cyl     Start      Size ID
>  1 00   2   4    0  55  55  967        129    3902335 06
>  2 00   0   0    0   0   0    0          0          0 00
>  3 00   0   0    0   0   0    0          0          0 00
>  4 00   0   0    0   0   0    0          0          0 00
> 
> Expert command (m for help): q
> 
> n22 ~ # fdisk -l /dev/sda
> 
> Disk /dev/sda: 1998 MB, 1998061056 bytes
> 56 heads, 55 sectors/track, 1267 cylinders
> Units = cylinders of 3080 * 512 = 1576960 bytes
> Disk identifier: 0x00000000
> 
>    Device Boot      Start         End      Blocks   Id  System
> /dev/sda1               1        1268     1951167+   6  FAT16
> 
> I deleted +created the partition both manually and by the digikam
> but w/o success...
  Hmm, ok. This doesn't look like a kernel bug. At least if you created the
partition table in linux by fdisk (or some other partitioning program), it
should have created the partition one sector shorter. So please report this
as a bug of the partitioning program. Thanks.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/