linux-kernel - Re: [2.6 patch] fs/udf/partition.c:udf_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2008 18:47:31 +0200
From:	Jan Kara <jack@...e.cz>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Alexander van Heukelum <heukelum@...lshack.com>,
	jdike@...toit.com, Ingo Molnar <mingo@...e.hu>
Subject: Re: [2.6 patch] fs/udf/partition.c:udf_get_pblock() mustn't be
	inline

On Mon 28-04-08 18:38:49, Adrian Bunk wrote:
> This patch fixes the following build error with UML and gcc 4.3:
> 
> <--  snip  -->
> 
> ...
>   CC      fs/udf/partition.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c: In function ‘udf_get_pblock_virt15’:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c:32: sorry, unimplemented: inlining failed in call to ‘udf_get_pblock’: function body not available
> /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/udf/partition.c:102: sorry, unimplemented: called from here
> make[3]: *** [fs/udf/partition.o] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
  Thanks. Merged into UDF git tree.

										Honza

> ---
> 9739b5f94fdf781f71cbb4c7b2f8f6d9e3d58e55 diff --git a/fs/udf/partition.c b/fs/udf/partition.c
> index 63610f0..96dfd20 100644
> --- a/fs/udf/partition.c
> +++ b/fs/udf/partition.c
> @@ -27,8 +27,8 @@
>  #include <linux/slab.h>
>  #include <linux/buffer_head.h>
>  
> -inline uint32_t udf_get_pblock(struct super_block *sb, uint32_t block,
> -			       uint16_t partition, uint32_t offset)
> +uint32_t udf_get_pblock(struct super_block *sb, uint32_t block,
> +			uint16_t partition, uint32_t offset)
>  {
>  	struct udf_sb_info *sbi = UDF_SB(sb);
>  	struct udf_part_map *map;
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/