linux-kernel - Re: [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output. take2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080429104318.GA9622@csn.ul.ie>
Date:	Tue, 29 Apr 2008 11:43:19 +0100
From:	Mel Gorman <mel@....ul.ie>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Shi Weihua <shiwh@...fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output.  take2

On (29/04/08 17:17), KOSAKI Motohiro didst pronounce:
> > > Index: b/mm/vmstat.c
> > > ===================================================================
> > > --- a/mm/vmstat.c       2008-04-29 16:48:58.000000000 +0900
> > > +++ b/mm/vmstat.c       2008-04-29 16:58:33.000000000 +0900
> > > @@ -638,6 +638,10 @@ static int pagetypeinfo_show(struct seq_
> > >  {
> > >         pg_data_t *pgdat = (pg_data_t *)arg;
> > > 
> > > +       /* check memoryless ndoe*/
> > 
> > ndoe -> node ?
> 
> Agghhh!
> you are right ;-)
> 
> fixed version is here.
> 

I see what you mean. The headers for a node with no populated zones looks
a bit odd. I was briefly thrown by the check for N_HIGH_MEMORY wondering
why it was not a check for N_NORMAL_MEMORY. A double-check showed that
N_NORMAL_MEMORY only has meaning on CONFIG_HIGHMEM machines and a check for
"any memory on the node" should use N_HIGH_MEMORY which is what you do.

So, your patch looks correct but unfortunately it is whitespace-damaged
and would not apply as-is. I included a whitespace-fixed version below for
convenience with a slightly clearer leader which I have acked.

Thanks

==========
On memoryless node, /proc/pagetypeinfo outputs headers for nodes with no
populated zones. This is confusing as shown in the following example.

>>>
Page block order: 14
Pages per block:  16384

Free pages count per migrate type at order       0      1      2      3      4      5      6      7      8      9     10     11     12     13     14     15     16

Number of blocks type     Unmovable  Reclaimable      Movable      Reserve      Isolate
Page block order: 14
Pages per block:  16384

Free pages count per migrate type at order       0      1      2      3      4      5      6      7      8      9     10     11     12     13     14     15     16
<SNIP>
<<<

Note the headers with no zone information. This patch checks if the node
has any memory before outputting anything.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Acked-by: Mel Gorman <mel@....ul.ie>
---
 mm/vmstat.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: b/mm/vmstat.c
===================================================================
--- a/mm/vmstat.c       2008-04-29 16:48:58.000000000 +0900
+++ b/mm/vmstat.c       2008-04-29 16:58:33.000000000 +0900
@@ -638,6 +638,10 @@ static int pagetypeinfo_show(struct seq_
 {
 	pg_data_t *pgdat = (pg_data_t *)arg;

+	/* check memoryless node */
+	if (!node_state(pgdat->node_id, N_HIGH_MEMORY))
+		return 0;
+
 	seq_printf(m, "Page block order: %d\n", pageblock_order);
 	seq_printf(m, "Pages per block:  %lu\n", pageblock_nr_pages);
 	seq_putc(m, '\n');

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/