linux-kernel - Re: [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output. take2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 Apr 2008 20:11:26 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	kosaki.motohiro@...fujitsu.com, Shi Weihua <shiwh@...fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] on memoryless node, /proc/pagetypeinfo is displayed slightly funny output.  take2

> I see what you mean. The headers for a node with no populated zones looks
> a bit odd. I was briefly thrown by the check for N_HIGH_MEMORY wondering
> why it was not a check for N_NORMAL_MEMORY. A double-check showed that
> N_NORMAL_MEMORY only has meaning on CONFIG_HIGHMEM machines and a check for
> "any memory on the node" should use N_HIGH_MEMORY which is what you do.
> 
> So, your patch looks correct but unfortunately it is whitespace-damaged
> and would not apply as-is. I included a whitespace-fixed version below for
> convenience with a slightly clearer leader which I have acked.

Oops, very sorry.
I'll check my MUA settings again.

and, very thank you for your excellent cleanups.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/