linux-kernel - RE: [PATCH 7/12] cciss: assign PDE->data before gluing PDE into /proc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DEE40752C8AF224BB890E455C7B8E0FE0452F8DF96@G6W0268.americas.hpqcorp.net>
Date:	Tue, 29 Apr 2008 15:26:58 +0000
From:	"Miller, Mike (OS Dev)" <Mike.Miller@...com>
To:	"Denis V. Lunev" <den@...nvz.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Alexey Dobriyan <adobriyan@...nvz.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	ISS StorageDev <iss_storagedev@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: RE: [PATCH 7/12] cciss: assign PDE->data before gluing PDE into
 /proc tree



> -----Original Message-----
> From: den@...ru [mailto:den@...ru] On Behalf Of Denis V. Lunev
> Sent: Tuesday, April 29, 2008 6:13 AM
> To: akpm@...ux-foundation.org
> Cc: linux-kernel@...r.kernel.org; Denis V. Lunev; Alexey
> Dobriyan; Eric W. Biederman; ISS StorageDev; Greg Kroah-Hartman
> Subject: [PATCH 7/12] cciss: assign PDE->data before gluing
> PDE into /proc tree
>
> Simply replace proc_create and further data assigned with
> proc_create_data.
>
> Signed-off-by: Denis V. Lunev <den@...nvz.org>
> Cc: Alexey Dobriyan <adobriyan@...nvz.org>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Cc: <iss_storagedev@...com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>

Acked-by: Mike Miller <mike.miller@...com>

> ---
>  drivers/block/cciss.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index e539be5..e336b05 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -428,13 +428,9 @@ static void __devinit cciss_procinit(int i)
>                 proc_cciss = proc_mkdir("driver/cciss", NULL);
>         if (!proc_cciss)
>                 return;
> -       pde = proc_create(hba[i]->devname, S_IWUSR | S_IRUSR
> | S_IRGRP |
> +       pde = proc_create_data(hba[i]->devname, S_IWUSR | S_IRUSR |
> + S_IRGRP |
>                                         S_IROTH, proc_cciss,
> -                                       &cciss_proc_fops);
> -       if (!pde)
> -               return;
> -
> -       pde->data = hba[i];
> +                                       &cciss_proc_fops, hba[i]);
>  }
>  #endif                         /* CONFIG_PROC_FS */
>
> --
> 1.5.3.rc5
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/