linux-kernel - Re: patch sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.pat ch added to gregkh-2.6 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080429152249.GB11329@kroah.com>
Date:	Tue, 29 Apr 2008 08:22:49 -0700
From:	Greg KH <greg@...ah.com>
To:	SL Baur <steve@...acs.org>
Cc:	"gregkh@...e.de" <gregkh@...e.de>, dan.j.williams@...el.com,
	akpm@...ux-foundation.org, hpa@...or.com, htejun@...il.com,
	kay.sievers@...y.org, linux-kernel@...r.kernel.org, lkml@....ca,
	neilb@...e.de
Subject: Re: patch
	sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.pat
	ch added to gregkh-2.6 tree

On Tue, Apr 29, 2008 at 12:48:11AM -0700, SL Baur wrote:
> On 4/28/08, gregkh@...e.de <gregkh@...e.de> wrote:
> >
> >  This is a note to let you know that I've just added the patch titled
> >
> >      Subject: sysfs: add /sys/dev/{char,block} to lookup sysfs path by major:minor
> >
> >  to my gregkh-2.6 tree.  Its filename is
> >
> >      sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch
> 
> >  +       char devt_str[15];
> >  +
> >  +       if (kobj) {
> >  +               format_dev_t(devt_str, dev->devt);
> 
> This part is ugly, but is not the fault of the patch.  The ill-
> considered interface for `format_dev_t' is something that probably
> noone wants to fix.

Why not?  Patches are always welcome, it's not like that function is
used in that many different places, should be a simple change...

> Otherwise, still OK with me.
> 
> Reviewed-by: SL Baur <steve@...acs.org>
> 
> (Is Reviewed-by not sticky?)

Yes, it is, I'll add it to my version of the patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/