lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ed10ee420804290048pb0070ffhaf2e9dffe6868ac5@mail.gmail.com>
Date:	Tue, 29 Apr 2008 00:48:11 -0700
From:	"SL Baur" <steve@...acs.org>
To:	"gregkh@...e.de" <gregkh@...e.de>
Cc:	dan.j.williams@...el.com, akpm@...ux-foundation.org,
	greg@...ah.com, hpa@...or.com, htejun@...il.com,
	kay.sievers@...y.org, linux-kernel@...r.kernel.org, lkml@....ca,
	neilb@...e.de
Subject: Re: patch sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch added to gregkh-2.6 tree

On 4/28/08, gregkh@...e.de <gregkh@...e.de> wrote:
>
>  This is a note to let you know that I've just added the patch titled
>
>      Subject: sysfs: add /sys/dev/{char,block} to lookup sysfs path by major:minor
>
>  to my gregkh-2.6 tree.  Its filename is
>
>      sysfs-add-sys-dev-char-block-to-lookup-sysfs-path-by-major-minor.patch

>  +       char devt_str[15];
>  +
>  +       if (kobj) {
>  +               format_dev_t(devt_str, dev->devt);

This part is ugly, but is not the fault of the patch.  The ill-
considered interface for `format_dev_t' is something that probably
noone wants to fix.

Otherwise, still OK with me.

Reviewed-by: SL Baur <steve@...acs.org>

(Is Reviewed-by not sticky?)

-sb
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ