linux-kernel - Re: [patch, -git] input: CONFIG_INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080430150021.ZZRA012@mailhub.coreip.homeip.net>
Date:	Wed, 30 Apr 2008 15:04:24 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Roman Zippel <zippel@...ux-m68k.org>
Subject: Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix

On Wed, Apr 30, 2008 at 08:54:16PM +0200, Ingo Molnar wrote:
> 
> x86.git testing found this build failure in upstream -git:
> 
>  drivers/built-in.o: In function `apanel_detach_client':
>  apanel.c:(.text+0x3027af): undefined reference to `led_classdev_unregister'
>  drivers/built-in.o: In function `apanel_probe':
>  apanel.c:(.text+0x302ac9): undefined reference to `led_classdev_register'
> 
> with this config:
> 
>  http://redhat.com/~mingo/misc/config-Wed_Apr_30_20_22_20_CEST_2008.bad
> 
> this driver has a missing CONFIG_NEW_LEDS dependency.

Thank you Ingo. Isn't this a Kconfig issue though? I know that Roman
is not willing to fix SELECT to evaluate the whole dependency chain,
but in this case it is "depens on" that does not evaluate properly...

> 
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  drivers/input/misc/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux/drivers/input/misc/Kconfig
> ===================================================================
> --- linux.orig/drivers/input/misc/Kconfig
> +++ linux/drivers/input/misc/Kconfig
> @@ -43,7 +43,7 @@ config INPUT_M68K_BEEP
>  
>  config INPUT_APANEL
>  	tristate "Fujitsu Lifebook Application Panel buttons"
> -	depends on X86 && I2C && LEDS_CLASS
> +	depends on X86 && I2C && LEDS_CLASS && NEW_LEDS
>  	select INPUT_POLLDEV
>  	select CHECK_SIGNATURE
>  	help
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/