linux-kernel - Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1209596078.3774.38.camel@localhost.localdomain>
Date:	Wed, 30 Apr 2008 17:54:38 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings

On Wed, 2008-04-30 at 15:34 -0700, Harvey Harrison wrote:
> On Wed, 2008-04-30 at 17:29 -0500, James Bottomley wrote:
> > On Wed, 2008-04-30 at 15:03 -0700, Harvey Harrison wrote:
> > > drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
> > > drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
> > > drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer
> 
> > The flashpoint initialiser changes look wrong:  {0} is a conventional
> > notation for zero initialise this structure.  Sparse should probably be
> > taught to recognise that.
> 
> Actually, looking closer, should this be initialized at all?  Can we
> just remove the initialization here and let them end up in .bss?

Yes, but the conventional initialiser doesn't change that (as in zero
initialise a static and it ends up in bss anyway).

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/