linux-kernel - Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080501002941.7e1e2f4a@core>
Date:	Thu, 1 May 2008 00:29:41 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings

> -				if (tw_dev->srb[request_id] != 0) {
> +				if (tw_dev->srb[request_id]) {

For pointers we should use == NULL or != NULL.

Removing the comparison removes the warning but it doesn't replace it
with any useful typechecking as can be doing with NULL set as (void *)0.

This is thus a backward step.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/