linux-kernel - Re: [PATCH] add typecheck on irqsave and friends for correct flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080501172810.fa39dad6.akpm@linux-foundation.org>
Date:	Thu, 1 May 2008 17:28:10 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, peterz@...radead.org,
	hch@...radead.org, adobriyan@...il.com, bunk@...nel.org
Subject: Re: [PATCH] add typecheck on irqsave and friends for correct flags

On Thu, 1 May 2008 19:51:18 -0400 (EDT)
Steven Rostedt <rostedt@...dmis.org> wrote:

> There has been several areas in the kernel where an int has been used
> for flags in local_irq_save and friends instead of a long. This can
> cause some hard to debug problems on some architectures.
> 
> This patch adds a typecheck inside the irqsave and restore functions
> to flag these cases.

hm, not exactly a thing of beauty, but it could have been worse.


If we had implemeted these things properly, as

	unsigned long spin_lock_irqsave(spinlock_t *lock);

then we wouldn't be able to do this at all.

Oh well, thanks, I'll toss it in there.  Maybe this should go into
git-sched (aka git-omnibus)?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/