linux-kernel - Re: [PATCH 5/7] PPS: serial clients support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 May 2008 13:56:18 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 5/7] PPS: serial clients support.

> So I should rewrite the uart_handle_dcd_change() as follow?
> 
> static inline void
> uart_handle_dcd_change(struct uart_port *port, unsigned int status)
> {
>         struct uart_info *info = port->info;
> 	struct tty_struct *tty = info->tty;
>         struct tty_ldisc *ld;
> 
>         ld = tty_ldisc_ref(tty);
>         if (ld != NULL) {
>                 if (ld->dcd_change)
>                         (ld->dcd_change)(tty, port, status);
>                 tty_ldisc_deref(ld);
>         }
> 
>         port->icount.dcd++;
> 
> #ifdef CONFIG_HARD_PPS
>         if ((port->flags & UPF_HARDPPS_CD) && status)
>                 hardpps();
> #endif

The ifdef bit can go - it will be in your dcd_change callback ..

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/