linux-kernel - Re: [PATCH 5/7] PPS: serial clients support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080502210959.GB8502@enneenne.com>
Date:	Fri, 2 May 2008 23:09:59 +0200
From:	Rodolfo Giometti <giometti@...eenne.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 5/7] PPS: serial clients support.

On Fri, May 02, 2008 at 01:56:18PM +0100, Alan Cox wrote:
> > So I should rewrite the uart_handle_dcd_change() as follow?
> > 
> > static inline void
> > uart_handle_dcd_change(struct uart_port *port, unsigned int status)
> > {
> >         struct uart_info *info = port->info;
> > 	struct tty_struct *tty = info->tty;
> >         struct tty_ldisc *ld;
> > 
> >         ld = tty_ldisc_ref(tty);
> >         if (ld != NULL) {
> >                 if (ld->dcd_change)
> >                         (ld->dcd_change)(tty, port, status);
> >                 tty_ldisc_deref(ld);
> >         }
> > 
> >         port->icount.dcd++;
> > 
> > #ifdef CONFIG_HARD_PPS
> >         if ((port->flags & UPF_HARDPPS_CD) && status)
> >                 hardpps();
> > #endif
> 
> The ifdef bit can go - it will be in your dcd_change callback ..

The "#ifdef CONFIG_HARD_PPS" is currently into kernel code, is *not*
my modification at all. In fact you can find the flag UPF_HARDPPS_CD
defined into include/linux/serial_core.h. It's a part of a very old
PPS implemention (never merged into mainline) and it was used to
enable the PPS layer for serial ports. That's why I didn't define an
ldisc but implemented my PPS version using it. :)

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@...eenne.com
Linux Device Driver                             giometti@...ux.it
Embedded Systems                     phone:	+39 349 2432127
UNIX programming                     skype:     rodolfo.giometti
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/