linux-kernel - Re: Horrendous Audio Stutter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1209756423.4693.8.camel@marge.simson.net>
Date:	Fri, 02 May 2008 21:27:03 +0200
From:	Mike Galbraith <efault@....de>
To:	Frans Pop <elendil@...net.nl>
Cc:	Parag Warudkar <parag.warudkar@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Horrendous Audio Stutter - current git


On Fri, 2008-05-02 at 20:53 +0200, Frans Pop wrote:
> On Friday 02 May 2008, Frans Pop wrote:
> > As I had group scheduling disabled, I only saw the first one. But my
> > audio skips were a lot less severe than Parag described. And disabling
> > group scheduling helped solve the problem for him.
> >
> > So it may well still be worth following up on this.
> 
> I have just tested a kernel with GROUP_SCHED enabled (with Peter's patch 
> still included) and can confirm that enabling group scheduling causes 
> serious latencies.
> Skips are much more frequent than with the issue that was just solved.
> 
> latencytop shows (different samples)
> Scheduler: waiting for cpu                        537.7 msec
> Scheduler: waiting for cpu                        172.0 msec 
> Scheduler: waiting for cpu                        414.6 msec
> Scheduler: waiting for cpu                        455.7 msec
> Scheduler: waiting for cpu                        446.5 msec
> 
> I think I also see why....
> 
> # grep bonus_max `grep -l amarokapp /proc/*/task/*/sched`
> /proc/4725/task/20645/sched:se.bonus_max  :        122640.203776
> /proc/4725/task/4725/sched:se.bonus_max  :        122640.203776
> /proc/4725/task/4793/sched:se.bonus_max  :      41902109.884416
> /proc/4725/task/4797/sched:se.bonus_max  :      41902109.884416
> /proc/4725/task/4798/sched:se.bonus_max  :      41902109.884416
> /proc/4725/task/4799/sched:se.bonus_max  :         40880.046080
> /proc/4725/task/4800/sched:se.bonus_max  :            19.970683

Hm. I enabled group scheduling, with Peter's patch + revert of the
commit that is giving me grief + the below, and it seems to work ok
here.  Definitely no sound skips even under quite hefty load.

The below _seems_ to make a difference stand-alone, but subjective
things like 'lurches' require _very_ much testing... you tend to see
what you want to see with such things.  As you can see, I thought about
submitting it, but I have way too much subjective poison in my system
from testing this and that while reading source.

Fix undesirable rq.clock update noops.

Signed-off-by: Mike Galbraith <efault@....de>

Index: linux-2.6.26.git/kernel/sched.c
===================================================================
--- linux-2.6.26.git.orig/kernel/sched.c
+++ linux-2.6.26.git/kernel/sched.c
@@ -668,9 +668,6 @@ static void __update_rq_clock(struct rq 
 	s64 delta = now - prev_raw;
 	u64 clock = rq->clock;
 
-#ifdef CONFIG_SCHED_DEBUG
-	WARN_ON_ONCE(cpu_of(rq) != smp_processor_id());
-#endif
 	/*
 	 * Protect against sched_clock() occasionally going backwards:
 	 */
@@ -3009,8 +3006,8 @@ static void double_rq_lock(struct rq *rq
 			spin_lock(&rq1->lock);
 		}
 	}
-	update_rq_clock(rq1);
-	update_rq_clock(rq2);
+	__update_rq_clock(rq1);
+	__update_rq_clock(rq2);
 }
 
 /*
@@ -3860,7 +3857,7 @@ redo:
 		/* Attempt to move tasks */
 		double_lock_balance(this_rq, busiest);
 		/* this_rq->clock is already updated */
-		update_rq_clock(busiest);
+		__update_rq_clock(busiest);
 		ld_moved = move_tasks(this_rq, this_cpu, busiest,
 					imbalance, sd, CPU_NEWLY_IDLE,
 					&all_pinned);
@@ -3959,8 +3956,8 @@ static void active_load_balance(struct r
 
 	/* move a task from busiest_rq to target_rq */
 	double_lock_balance(busiest_rq, target_rq);
-	update_rq_clock(busiest_rq);
-	update_rq_clock(target_rq);
+	__update_rq_clock(busiest_rq);
+	__update_rq_clock(target_rq);
 
 	/* Search for an sd spanning us and the target CPU. */
 	for_each_domain(target_cpu, sd) {
Index: linux-2.6.26.git/kernel/sched_fair.c
===================================================================
--- linux-2.6.26.git.orig/kernel/sched_fair.c
+++ linux-2.6.26.git/kernel/sched_fair.c
@@ -1221,7 +1221,7 @@ static void check_preempt_wakeup(struct 
 	int se_depth, pse_depth;
 
 	if (unlikely(rt_prio(p->prio))) {
-		update_rq_clock(rq);
+		__update_rq_clock(rq);
 		update_curr(cfs_rq);
 		resched_task(curr);
 		return;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/