linux-kernel - Re: Horrendous Audio Stutter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 May 2008 21:38:43 +0200
From:	Mike Galbraith <efault@....de>
To:	Frans Pop <elendil@...net.nl>
Cc:	Parag Warudkar <parag.warudkar@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Horrendous Audio Stutter - current git


On Fri, 2008-05-02 at 17:49 +0200, Frans Pop wrote:
> On Friday 02 May 2008, Mike Galbraith wrote:
> > On Fri, 2008-05-02 at 14:37 +0200, Mike Galbraith wrote:
> > > On Fri, 2008-05-02 at 08:21 -0400, Parag Warudkar wrote:
> > > > On Fri, May 2, 2008 at 8:09 AM, Mike Galbraith <efault@....de> wrote:
> > > > >  Hm.  I've stumbled across a regression that may be related.  Can
> > > > > you please try the attached with group scheduling enabled in
> > > > > current git?
> > > >
> > > > In file included from kernel/sched.c:1902:
> > > > kernel/sched_fair.c: In function 'print_cfs_rq_tasks':
> > > > kernel/sched_fair.c:1602: error: implicit declaration of function
> > > > 'calc_delta_weight'
> > > > kernel/sched_fair.c:1603: warning: format '%lu' expects type 'long
> > > > unsigned int', but argument 5 has type 'int'
> > > > make[1]: *** [kernel/sched.o] Error 1
> > > > make: *** [kernel] Error 2
> > > >
> > > > 'calc_delta_weight' or a replacement not found easily to fix it up!
> > >
> > > Oops, I have an unrelated patch in my tree which you also need.
> >
> > I see that Peter has a fix, so don't bother.
> 
> Maybe not. It looks like Parag may have been seeing a combination of two 
> different issues: the one that Peter fixed and one related to group 
> scheduling.

There are definitely issues with that commit, but I'm not at all sure
they manifest themselves with this workload in any heavy-weight way.  My
thought was only that it's negative effects could be compounded by group
scheduling.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/