linux-kernel - Re: [PATCH REPOST] CPA: Add statistics about state of direct mapping v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805051208240.3318@apollo.tec.linutronix.de>
Date:	Mon, 5 May 2008 12:13:51 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andi Kleen <andi@...stfloor.org>
cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH REPOST] CPA: Add statistics about state of direct mapping
 v4

On Fri, 2 May 2008, Andi Kleen wrote:
> 
> Signed-off-by: Andi Kleen <ak@...e.de>
> Signed-off-by: Andi Kleen <andi@...stfloor.org>

Interesting SOB chain :)

> +static unsigned long direct_pages_count[PG_LEVEL_NUM];
> +
> +void __meminit update_page_count(int level, unsigned long pages)

Why __meminit ? This is used in split_large_page()

> +{
> +#ifdef CONFIG_PROC_FS

Why keep an empty function when PROC_FS is disabled ?

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/