linux-kernel - Re: [PATCH REPOST] CPA: Add statistics about state of direct mapping v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <481EE031.3090303@firstfloor.org>
Date:	Mon, 05 May 2008 12:23:45 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH REPOST] CPA: Add statistics about state of direct mapping
 v4


>> +static unsigned long direct_pages_count[PG_LEVEL_NUM];
>> +
>> +void __meminit update_page_count(int level, unsigned long pages)
> 
> Why __meminit ? This is used in split_large_page()

True. Can you please just remove it? I think it came when this
was still only used in early memory init.

[insert standard rant about the work:code size benefit ratio of these
fine grained section identifiers being far too high]

>> +{
>> +#ifdef CONFIG_PROC_FS
> 
> Why keep an empty function when PROC_FS is disabled ?

So we don't have to add a ifdef in all the callers. Yes could probably
have an empty inline in that case in some header, but frankly that would
be a lot of code lines for saving only very minor code size in a very
unlikely CONFIG case.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/