linux-kernel - Re: [PATCH] x86: remove printk compiling warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080507083946.49a3b5ab.rdunlap@xenotime.net>
Date:	Wed, 7 May 2008 08:39:46 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Li Zefan <lizf@...fujitsu.com>, akpm <akpm@...ux-foundation.org>,
	sfr@...b.auug.org.au
Cc:	Shen Feng <shen@...fujitsu.com>, hpa@...or.com,
	linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH] x86: remove printk compiling warning

On Wed, 07 May 2008 16:27:11 +0800 Li Zefan wrote:

> CC: Randy Dunlap <rdunlap@...otime.net>
> 
> Shen Feng wrote:
> > Since size is unsigned long, the format string is changed
> > from zd to lu.
> > 
> > Signed-off-by: Shen Feng <shen@...fujitsu.com>
> > ---
> >  arch/x86/kernel/setup.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> > index cc6f5eb..c0c68c1 100644
> > --- a/arch/x86/kernel/setup.c
> > +++ b/arch/x86/kernel/setup.c
> > @@ -95,7 +95,7 @@ void __init setup_per_cpu_areas(void)
> > 
> >  	/* Copy section for each CPU (we discard the original) */
> >  	size = PERCPU_ENOUGH_ROOM;
> > -	printk(KERN_INFO "PERCPU: Allocating %zd bytes of per cpu data\n",
> > +	printk(KERN_INFO "PERCPU: Allocating %lu bytes of per cpu data\n",
> >  			  size);
> > 
> >  	for_each_possible_cpu(i) {
> 
> Let me figure out this.
> 
> Commit 0fc5035fc66d26776bebd45c508a9bce3611f388 in linux-next changed
> 'size' from unsigned long to ssize_t, causing a compile warning, and
> then Randy posted a patch to fix it:
> 	http://marc.info/?l=linux-kernel&m=120958902125650&w=2
> 
> But this patch was wrongly merged into mainline, causing the compile warning
> you described here.
> 
> So we should revert Randy's patch and re-apply it to linux-next ?

Hi,
Thanks for the detective work.  I hadn't looked into this yet.

Yes, my patch was sent for linux-next.  How are we supposed to
keep this straightened out?

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/